Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update application design #410

Merged
merged 6 commits into from
Mar 5, 2022
Merged

Update application design #410

merged 6 commits into from
Mar 5, 2022

Conversation

paper-lark
Copy link
Contributor

First of all, thank you for this awesome app!
I've made some changes to the UI and I wondered if you would like to merge them. I did not make any changes to the logic of the app – only the looks. Below is a screenshot of the result.

Screenshot 2022-02-27 at 19 59 32

@kdheepak
Copy link
Owner

kdheepak commented Feb 27, 2022

Wow! Thanks for taking this on! I personally really like it (from the screenshot). It brings taskwarrior-tui more in line with the taskwarrior command line interface too. I also like that you cleaned up the code too :)

Let me get back to my computer and use it, and see if I have any other feedback. But, yes I'd be very happy to merge this!

@kdheepak
Copy link
Owner

It looks good to me. I might make more changes once I refactor the code too.

There's a bunch of formatting and clippy warnings. Would you like to deal with them or should I?

@paper-lark
Copy link
Contributor Author

Thanks for the feedback! I will fix formatting a bit later.

@paper-lark
Copy link
Contributor Author

Strangely, I did not see clippy warning from the latest build when running the same command locally. Anyhow, seems by now I should have fixed them all

@kdheepak
Copy link
Owner

kdheepak commented Mar 3, 2022

Probably a new rust / clippy version? Thanks for making all the changes.

@kdheepak kdheepak merged commit ed3cef4 into kdheepak:main Mar 5, 2022
@paper-lark paper-lark deleted the redesign branch March 5, 2022 07:39
@kdheepak
Copy link
Owner

kdheepak commented Mar 5, 2022

Light mode screenshot comparing old version and new version:

Screen Shot 2022-03-05 at 12 43 26 AM

@kdheepak
Copy link
Owner

I've made a new release with this redesign: https://github.com/kdheepak/taskwarrior-tui/releases/tag/v0.21.0

Thanks for submitting the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants