Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nom dependency on bitvec and lexical #14

Merged
merged 2 commits into from
May 8, 2021

Conversation

jam1garner
Copy link
Contributor

Dependencies before:

Click to expand
kdl v1.0.0 (/home/jam/dev/kdl-rs)
├── nom v6.1.2
│   ├── bitvec v0.19.5
│   │   ├── funty v1.1.0
│   │   ├── radium v0.5.3
│   │   ├── tap v1.0.1
│   │   └── wyz v0.2.0
│   ├── funty v1.1.0
│   ├── lexical-core v0.7.6
│   │   ├── arrayvec v0.5.2
│   │   ├── bitflags v1.2.1
│   │   ├── cfg-if v1.0.0
│   │   ├── ryu v1.0.5
│   │   └── static_assertions v1.1.0
│   └── memchr v2.4.0
│   [build-dependencies]
│   └── version_check v0.9.3
├── phf v0.8.0
│   ├── phf_macros v0.8.0 (proc-macro)
│   │   ├── phf_generator v0.8.0
│   │   │   ├── phf_shared v0.8.0
│   │   │   │   └── siphasher v0.3.5
│   │   │   └── rand v0.7.3
│   │   │       ├── getrandom v0.1.16
│   │   │       │   ├── cfg-if v1.0.0
│   │   │       │   └── libc v0.2.94
│   │   │       ├── libc v0.2.94
│   │   │       ├── rand_chacha v0.2.2
│   │   │       │   ├── ppv-lite86 v0.2.10
│   │   │       │   └── rand_core v0.5.1
│   │   │       │       └── getrandom v0.1.16 (*)
│   │   │       ├── rand_core v0.5.1 (*)
│   │   │       └── rand_pcg v0.2.1
│   │   │           └── rand_core v0.5.1 (*)
│   │   ├── phf_shared v0.8.0 (*)
│   │   ├── proc-macro-hack v0.5.19 (proc-macro)
│   │   ├── proc-macro2 v1.0.26
│   │   │   └── unicode-xid v0.2.2
│   │   ├── quote v1.0.9
│   │   │   └── proc-macro2 v1.0.26 (*)
│   │   └── syn v1.0.72
│   │       ├── proc-macro2 v1.0.26 (*)
│   │       ├── quote v1.0.9 (*)
│   │       └── unicode-xid v0.2.2
│   ├── phf_shared v0.8.0 (*)
│   └── proc-macro-hack v0.5.19 (proc-macro)
└── thiserror v1.0.24
    └── thiserror-impl v1.0.24 (proc-macro)
        ├── proc-macro2 v1.0.26 (*)
        ├── quote v1.0.9 (*)
        └── syn v1.0.72 (*)

Dependencies after:

Click to expand
kdl v1.0.0 (/home/jam/dev/kdl-rs)
├── nom v6.1.2
│   └── memchr v2.4.0
│   [build-dependencies]
│   └── version_check v0.9.3
├── phf v0.8.0
│   ├── phf_macros v0.8.0 (proc-macro)
│   │   ├── phf_generator v0.8.0
│   │   │   ├── phf_shared v0.8.0
│   │   │   │   └── siphasher v0.3.5
│   │   │   └── rand v0.7.3
│   │   │       ├── getrandom v0.1.16
│   │   │       │   ├── cfg-if v1.0.0
│   │   │       │   └── libc v0.2.94
│   │   │       ├── libc v0.2.94
│   │   │       ├── rand_chacha v0.2.2
│   │   │       │   ├── ppv-lite86 v0.2.10
│   │   │       │   └── rand_core v0.5.1
│   │   │       │       └── getrandom v0.1.16 (*)
│   │   │       ├── rand_core v0.5.1 (*)
│   │   │       └── rand_pcg v0.2.1
│   │   │           └── rand_core v0.5.1 (*)
│   │   ├── phf_shared v0.8.0 (*)
│   │   ├── proc-macro-hack v0.5.19 (proc-macro)
│   │   ├── proc-macro2 v1.0.26
│   │   │   └── unicode-xid v0.2.2
│   │   ├── quote v1.0.9
│   │   │   └── proc-macro2 v1.0.26 (*)
│   │   └── syn v1.0.72
│   │       ├── proc-macro2 v1.0.26 (*)
│   │       ├── quote v1.0.9 (*)
│   │       └── unicode-xid v0.2.2
│   ├── phf_shared v0.8.0 (*)
│   └── proc-macro-hack v0.5.19 (proc-macro)
└── thiserror v1.0.24
    └── thiserror-impl v1.0.24 (proc-macro)
        ├── proc-macro2 v1.0.26 (*)
        ├── quote v1.0.9 (*)
        └── syn v1.0.72 (*)

Copy link
Member

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! Thank you!

@zkat zkat merged commit 40b9805 into kdl-org:main May 8, 2021
zkat pushed a commit that referenced this pull request May 8, 2021
@CAD97
Copy link
Contributor

CAD97 commented Sep 22, 2021

nom 7.0.0 removes the mandatory bitvec dependency, btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Disable the nom bitvec feature
3 participants