feat(len): add APIs to calculate component lengths #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19
This adds some convenience methods that will make #19 possible, although it still needs some manual funging, unfortunately. There's no good way to maintain consistent spans across a document, partly due to limitations of how
nom
works, partly because, in practice, they would quickly go out of sync as soon as theKdlDocument
or any of its components get edited.So my suggestion is to use these new
len()
APIs to do manual offset calculations in your documents to come up with sensible spans and error messages for the particular failure cases of your KDL-based DSLs. You should then be able to throw the spans you come up with atmiette
to get some nice error message rendering, to boot! :)Anyway, I hope this helps. It's unfortunate I couldn't come up with something that does more heavy lifting, and I'm always open to accepting patches to allow that, if anyone else ends up having any brilliant ideas on how to get that working right.