Crash when loading texture groups

[ldicker83]

fctf4-crash.txt
fctf4-crash.log
fctf4-crash.zip

System Information

TB v2.0.0-final on Windows 10

Expected Behavior

Was adding texture collections to the map. After hitting the add button TB crashes.

In the case of a crash, please upload the generated stack trace, log file, and map file along with this report.

Thank you very much!

[kduske]

Which texture collection were you trying to add? Can you reproduce the problem?

[ldicker83]

It's actually any of the collections and I realized after the fact that it happens after loading another map.

Steps are basically, load a map. Add texture collections.

Load another map. Add a collection and it immediately crashes. I haven't had the time to look into it yet myself (I have a forked version of TB I'm using for a project of mine) otherwise I'd have submitted a patch/pull request.

[kduske]

No, I still cannot reproduce this. Sorry. I created a new map, added two texture collections, and saved it. Then I created another new map, added other texture collections, and saved that too. Then I restarted the editor, loaded the first map, added a texture collection. Then, without saving, I opened the second map, and added a texture collection. No crash. Do you have any other hints?

[ldicker83]

It could be that it's because I'm loading maps that were originally built in Qoole many years ago?

It's barfing in this function (file DirectoryTextureCollectionEditor.cpp, line 192):

        void DirectoryTextureCollectionEditor::updateListBox(wxListBox* box, const IO::Path::List& paths) {
            wxArrayString values;
            values.reserve(paths.size());
            
            for (const IO::Path& path : paths)
                values.push_back(path.asString()); // breaks here
            
            box->Set(values);
        }

I've been running this in the debugger and it's an access violation of sorts. Interestingly enough values can't be read by the debugger (values Error reading register value.) when in release builds so probably something to do with the optimizer.

As a side note, I'm seeing this only happening in release builds. When I build in Debug mode, the problem disappears. Makes me wonder if this is a side effect of the optimizer?

[kduske]

Alright, found the problem: DirectoryTextureCollectionEditor did not have a destructor, thus it never called unbindObservers. But when you load a new map on windows, the texture collection UI is destroyed and created anew because it might choose a different UI depending on which game you are editing.

But then, the old observer was still called and executed on the now deleted texture collection editor, leading to the crash.