Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Clipping With 2 Points Sometimes Fails When Points Coincide on Separate Brush Edge #2478

Closed
JosiahJack opened this issue Dec 5, 2018 · 4 comments
Assignees
Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Type:Bug Errors and problems
Milestone

Comments

@JosiahJack
Copy link

System Information

TrenchBroom V2.1.0-RC4 on Windows 7

Expected Behavior

Click to add clipping point. Click to add 2nd point. Clipping plane appears. Hit enter to clip.

Steps to Reproduce

Create 2 clipping points on the face of a brush where the 2 points are directly on the edge of an adjacent unselected brush (e.g. clipping a wall at the same level as the floor right next to it to split the wall vertically, floor is partway up the wall). If you hide the floor brush or move the camera view inside the floor brush that isn't selected and then put clipping points in the exact same positions it works fine and generates a clipping plane. Adding a 3rd point always works if the first 2 fail.

@kduske kduske added Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Type:Bug Errors and problems labels Dec 5, 2018
@kduske kduske self-assigned this Jan 6, 2019
@kduske
Copy link
Collaborator

kduske commented Jan 6, 2019

@JosiahJack please provide a screenshot of the situation and attach a map containing only the participating brushes.

@kduske kduske added this to the 2019.1 milestone Jan 6, 2019
@ericwa
Copy link
Collaborator

ericwa commented Jan 8, 2019

Here's how I reproduce it:

  1. add a wall and select it
    clip1

  2. place these two clip points:
    clip2

    What's weird is I get some randomness; sometimes after placing the first 2 clip points you'll get the desired clip suggestion:
    clip2b

  3. Placing the clip points higher up always works:
    clip3
    clipbug.map.txt

@kduske
Copy link
Collaborator

kduske commented Jan 8, 2019

Thanks! I'll look into this tomorrow.

@JosiahJack
Copy link
Author

Exactly! What ericw posted. Doesn't seem to be dependent on the axis or the angle. What's odd is that if I drag one of the two points after clicking to place it down it still doesn't make a clip plane appear. I have to escape out or add a 3rd point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Type:Bug Errors and problems
Projects
None yet
Development

No branches or pull requests

3 participants