1943: Strange behaviour whith some Fly Mode key bindings #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericwa never mind the checks, I cancelled them in error. |
ericwa
requested changes
Jan 3, 2018
common/src/View/FlyModeHelper.cpp
Outdated
| if (forward.matches(event)) { | ||
|
|
||
| bool anyMatch = false; | ||
| if (!m_forward && forward.matchesKeyDown(event)) { |
There was a problem hiding this comment.
I think the !m_forward (same with back, etc) part of the condition should be removed so that key repeats are still consumed. Otherwise I get the macOS bell sound when I hold down W,A,S or D.
|
Thanks! |
ericwa
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1943.
Using modifiers for fly keys is still a bit dodgy, but there really is no good way to fix this because we cannot query the entire keyboard state reliably.