This repository has been archived by the owner on Feb 5, 2023. It is now read-only.
updating swiftpm structure references #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went to try this on swift on Linux, since a cursory review made it look like it might work nicely. The swiftPM references were missing a bit to trigger the tests, so I wanted to offer this minor update back which helps (but doesn't fully) resolve it.
I wasn't sure why
Host(which seems to be UIKit/IOS specific) was under theTestsdirectory, but when I removed then all the tests were able to run locally (and remotely). Shifting the tests down one more directory and updating thepathreference in the testTarget would likely fully resolve this. I wanted to check and see if this update was of interest before making the relevant tweaks.If you're game to support swift for linux with this, I might also recommend replacing arc4random with some of the unified random number generators (such as https://developer.apple.com/documentation/swift/randomnumbergenerator).