-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ios 11 crash #695
Comments
Hey, just tried to reproduce the failing test and yes! It's failing. Given image: (W:151, H:150), and the test is already exist:
Failing with: I'm working on it and will make a PR. |
zzmasoud
added a commit
to zzmasoud/Nuke
that referenced
this issue
May 3, 2023
…150) to get a failing test
kean
added a commit
that referenced
this issue
May 3, 2023
Fix #695: byCroppingToSquare() always return square image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I find that when the source image's width bigger than height just 1 pixel, then after called cropping, the result is same to source image. so, image's width is not equal to the height. we should use min(width, height) as radius. Can you fix it?
The text was updated successfully, but these errors were encountered: