Add associated Data to ImagePipeline.Error.decodingFailed #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please update the unit tests? If you run them locally, you'll see what the issues are. |
freak4pc
force-pushed
the
add-decoding-error
branch
from
193d544
to
90d72cc
Compare
|
@kean my bad, I opened Package.swift directly and it doesn't have the tests targets :) |
kean
reviewed
Jun 9, 2022
| @@ -68,7 +68,7 @@ final class TaskFetchDecodedImage: ImagePipelineTask<ImageResponse> { | |||
| if let response = response { | |||
| send(value: response, isCompleted: isCompleted) | |||
| } else if isCompleted { | |||
| send(error: .decodingFailed) | |||
| send(error: .decodingFailed(response?.container.data ?? Data())) | |||
There was a problem hiding this comment.
@freak4pc, I was reworking this code for Nuke 11 and just noticed that it never attaches data. In this code block response is always nil.
There was a problem hiding this comment.
That's interesting. So where would we be able fetching the "right" Data from?
There was a problem hiding this comment.
I'll fix it in the patch release later today.
There was a problem hiding this comment.
The issue is that ImageResponse is always nil in this block – decoding failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion at #544