-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Apples swift-log #1
Comments
I was aware of swift-log, but for some reason didn't consider using it. I think it is a good idea, and should be an easy change. |
Cool, I鈥檇 be happy to help out with that. |
Awesome, if you'd like to work on it, please go ahead. I'm currently working on adding some limits (expiration/size) to the store size. And then I'm going to wait to see if there is more feedback to address. A have a public board where I manage tasks https://trello.com/b/GeR3MMdt/pulse |
Sounds good 馃憤 I鈥檒l look into it and create a draft PR so we can discuss the details. |
Hey, @slashmo. Thanks again for such a large contribution. I made some minor changes like removing timing dependencies from the unit tests, updated documentation, and I released all of the changes in Pulse 0.3. I also made some massive changes to PulseUI to accommodate swift-log. I'm now facing a lot of open questions like how to handle label, metadata, file, line, and all of this additional data. If you are interested in using/contributing to PulseUI, I might give you access to the repo. Please reach out to me in direct messages on Twitter. |
I love the iOS Console app. Looks like a definite time saver 馃憣
Did you already consider using apple/swift-log and writing a custom backend for Pulse (storing to CoreData) instead of writing your own top-level API?
The text was updated successfully, but these errors were encountered: