Store messages as swift-log backend

[slashmo]

This is still very much WIP, but should be enough to start a deeper discussion around whether this makes sense for Pulse. I've inlined some #warning()s for points that need to be considered.

Questions

• When/where should sweeping be scheduled?

• Can system be replaced by swift-logs labels?

• Should we store swift-logs metadata as well? (see Store metadata persistently #3)

• What's the equivalent of category in PersistentLogHandler?

• Closes Using Apples swift-log #1

[slashmo]

@kean I removed the Linux test files from the Swift package as this project is for Apple platforms only anyways and those files would only have to be updated each time the tests are updated.

[kean]

1. When/where should sweeping be scheduled?

I think it should be moved to LoggerMessageStore init. expirationInterval should be a parameter of LoggerMessageStore too.

2. Can system be replaced by swift-logs labels?

Yes, it should be replaced by label, and category should be removed - you can use metadata instead. Feel free to make breaking changes in the data model, nobody is using this yet.

3. Should we store swift-logs metadata as well?

Yes, see my comment.

4. What's the equivalent of category in PersistentLogHandler?

See answer to 2.

[kean]

Thanks for putting this together, @slashmo. This is a fantastic change, I agree with all of the changes that you made, including renaming the components.

Thanks for adding some unit tests too. I enabled Travis CI for this repo. All it needs a configuration file now. Feel free to add it if you are interested, or I could do that later today once this is merged.

[slashmo]

I enabled Travis CI for this repo. All it needs a configuration file now. Feel free to add it if you are interested, or I could do that later today once this is merged.

I guess this can be tracked in a separate issue. I haven't worked with Travis recently, though I could help with setting up GitHub Actions if you'd want to use that instead.

[kean]

A good idea, let me try using GitHub Actions for this repo. I'll track it separately.

[slashmo]

@kean I think this can transition into a real PR now. I guess the only thing left to update is the setup instructions in the README.

[kean]

Thanks! I’ll review this as soon as I can and will take care of README.

…

On 6 May 2020, at 14:12, Moritz Lang ***@***.***> wrote:  @kean I think this can transition into a real PR now. I guess the only thing left to update is the setup instructions in the README. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.