Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order exported items by creation date #261

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

goranbrl
Copy link
Contributor

@goranbrl goranbrl commented Jun 6, 2024

In our project, we noticed that the logs could sometimes end up in a scrambled order during export, especially if they were created pretty much simultaneously (down to a few milliseconds).

After some investigation, it seems like explicitly adding the sort descriptor seems to have resolved our issue, so I'd like to propose this update to the tool as well.

@kean
Copy link
Owner

kean commented Jun 6, 2024

Thanks for adding it. Right, it appears that this predicate was just missing – it has to sort by date.

@kean kean added the bug Something isn't working label Jun 6, 2024
@kean kean merged commit 578df05 into kean:main Jun 6, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants