Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer was done to early #39

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Defer was done to early #39

merged 1 commit into from
Sep 14, 2021

Conversation

mackoj
Copy link
Contributor

@mackoj mackoj commented Sep 14, 2021

No description provided.

@kean
Copy link
Owner

kean commented Sep 14, 2021

I'm a bit surprised it compiles. Is there any difference where it's placed exactly? I'm not sure there is even a need for a defer.

@kean kean merged commit b8985d1 into kean:master Sep 14, 2021
@kean
Copy link
Owner

kean commented Sep 15, 2021

Now I know why I didn't spot the issue. It compiles in Xcode 12, but not Xcode 13 – #40. Thanks for the fix.

@klemenkosir
Copy link
Contributor

Oh interesting, missed that one completely. Good to know Xcode 13 is a bit "stricter".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants