Fixed multi-threading crash when copying a store #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the store is a .directory type and
public func copy(to targetURL: URL) throws
is called, the copy in that method is performed on the backgroundContext. In theprivate func copy(to targetURL: URL, tempURL: URL, blobs: BlobStore)
that is called, the manifest is created usingLoggerStoreInfo
which callstry messageCount()
andtry networkRequestsCount()
. Both of these methods do their fetch usingcontainer.viewContext
which is a different thread leading to a crash.You can verify the crash by using the
com.apple.CoreData.ConcurrencyDebug 1
runtime flag (see [https://oleb.net/blog/2014/06/core-data-concurrency-debugging/](Core Data Concurrency Debugging) and then exporting the LoggerStore.By getting the counts on the same thread, this crash is eliminated.