Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFBundleVersion missing in xcframework files #11

Closed
ethan021021 opened this issue Apr 12, 2021 · 5 comments
Closed

CFBundleVersion missing in xcframework files #11

ethan021021 opened this issue Apr 12, 2021 · 5 comments

Comments

@ethan021021
Copy link

In Pulse / PulseUI it seems the frameworks are missing a CFBundleVersion in the Info.plist for the frameworks. Would you mind adding values in there? Looks like I can't submit my app to AppStore Connect without them having a CFBundleVersion.

@kean
Copy link
Owner

kean commented Apr 12, 2021

Fixed in https://github.com/kean/PulseUI/releases/tag/0.14.2

Screen Shot 2021-04-12 at 15 43 23

There is an issue with swift-create-xcframework where they don't add CFBundleVersion by default https://github.com/unsignedapps/swift-create-xcframework/issues/37. I haven't encountered it with my apps because I was building from source.

@ethan021021
Copy link
Author

Thanks a ton for adding that so quickly! Appreciate it

@finnsch
Copy link

finnsch commented Apr 27, 2021

The same problem occurs in the latest version 0.15.0. I reverted back to 0.14.2 for now.

@jojost1
Copy link

jojost1 commented Apr 27, 2021

Same for me, it's back in 0.15.0.

@kean
Copy link
Owner

kean commented Apr 27, 2021

Fixed in https://github.com/kean/Pulse/releases/tag/0.15.1. I need to add more automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants