Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SettingsView public #67

Closed
martindaum opened this issue Feb 12, 2022 · 2 comments
Closed

Make SettingsView public #67

martindaum opened this issue Feb 12, 2022 · 2 comments

Comments

@martindaum
Copy link
Contributor

I added Pulse to my project and it is working like a charm. I didn't want to use the MainView, because I would like to add the individual views from my main SettingsView. I have seen the PulseUI.SettingsView is not public, thus I am not able to add that as well. But I would need that too to enable Remote Logging. Would it be possible to make this view public?

Thanks,
Martin
@kean
Copy link
Owner

kean commented Feb 12, 2022

I agree it should be public. Currently, the only way to show settings is to use MainView that contains it.

@martindaum martindaum mentioned this issue Feb 12, 2022
Merged
@kean
Copy link
Owner

kean commented Mar 13, 2022

Implemented in #68

@kean kean closed this as completed Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kean @martindaum