Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage tool excoveralls to see where one might imporve #163

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

PragTob
Copy link
Collaborator

@PragTob PragTob commented Mar 19, 2017

Remembered saying that a couple of tests were still missing, so
this would be a nice first step to get them there.

If you create an account at coveralls
and activate it then mix coveralls.travis could be used as
the test script to collect test coverage data on CI run
(I have this setup for benchee)

That also comes with a nice little badge :)

FYI as of this commit:


COV FILE LINES RELEVANT MISSED
100.0% lib/wallaby.ex 59 10 0
74.6% lib/wallaby/browser.ex 1091 240 61
0.0% lib/wallaby/dsl.ex 12 0 0
76.9% lib/wallaby/element.ex 184 26 6
64.3% lib/wallaby/exceptions.ex 93 14 5
100.0% lib/wallaby/helpers/key_codes.ex 74 6 0
8.3% lib/wallaby/metadata.ex 51 12 11
73.3% lib/wallaby/phantom.ex 83 15 4
67.8% lib/wallaby/phantom/driver.ex 428 118 38
100.0% lib/wallaby/phantom/log_store.ex 26 7 0
100.0% lib/wallaby/phantom/logger.ex 23 6 0
96.7% lib/wallaby/phantom/server.ex 105 30 1
100.0% lib/wallaby/query.ex 289 35 0
78.6% lib/wallaby/query/error_message.ex 173 28 6
100.0% lib/wallaby/query/xpath.ex 77 11 0
0.0% lib/wallaby/session.ex 58 2 2
100.0% test/support/session_case.ex 19 4 0
57.1% test/support/test_server.ex 27 7 3
[TOTAL] 76.0%


Generating report...

I also promise, this is the last PR for today 😁

Remembered saying that a couple of tests were still missing, so
this would be a nice first step to get them there.

If you create an account at [coveralls](https://coveralls.io/)
and activate it then `mix coveralls.travis` could be used as
the test script to collect test coverage data on CI run
(I have this setup for benchee)

FYI as of this commit:

----------------
COV    FILE                                        LINES RELEVANT   MISSED
100.0% lib/wallaby.ex                                 59       10        0
 74.6% lib/wallaby/browser.ex                       1091      240       61
  0.0% lib/wallaby/dsl.ex                             12        0        0
 76.9% lib/wallaby/element.ex                        184       26        6
 64.3% lib/wallaby/exceptions.ex                      93       14        5
100.0% lib/wallaby/helpers/key_codes.ex               74        6        0
  8.3% lib/wallaby/metadata.ex                        51       12       11
 73.3% lib/wallaby/phantom.ex                         83       15        4
 67.8% lib/wallaby/phantom/driver.ex                 428      118       38
100.0% lib/wallaby/phantom/log_store.ex               26        7        0
100.0% lib/wallaby/phantom/logger.ex                  23        6        0
 96.7% lib/wallaby/phantom/server.ex                 105       30        1
100.0% lib/wallaby/query.ex                          289       35        0
 78.6% lib/wallaby/query/error_message.ex            173       28        6
100.0% lib/wallaby/query/xpath.ex                     77       11        0
  0.0% lib/wallaby/session.ex                         58        2        2
100.0% test/support/session_case.ex                   19        4        0
 57.1% test/support/test_server.ex                    27        7        3
[TOTAL]  76.0%
----------------
Generating report...
@keathley
Copy link
Member

Send as many PRs as you want! I think adding coveralls is fine, especially if it can help folks get involved. I added wallaby to coveralls so we should be able to update the travis config and start capturing those data.

@keathley keathley merged commit 54b2ebb into elixir-wallaby:master Mar 20, 2017
@PragTob PragTob deleted the test-coverage-setup branch March 20, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants