Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name guide argument in hGraph() #115

Merged
merged 1 commit into from Jan 31, 2024
Merged

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break gMCPLite. The culprit of the breakage is that we have made the name argument of scales the first, see tidyverse/ggplot2#5583.

Given that there are some overlapping contributors/authors, I can disclose that this essentially repeats Merck/gMCPLite#25 for the same reason, but for gsDesign. I noticed the deprecation warnings about the gsDesign::hGraph() function in favour of the gMCPLite one, but decided that the courteous thing to do is to put in a seperate PR anyway.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled at the end of January / early Februari. The progress can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help gsDesign get out a fix if necessary.

Please, feel entirely free to close this PR if gMCPLite::hGraph() will replace gsDesign::hGraph().

@keaven keaven merged commit e093512 into keaven:master Jan 31, 2024
9 checks passed
@teunbrand teunbrand deleted the ggplot2_3.5.0 branch January 31, 2024 19:48
@nanxstats
Copy link
Collaborator

Thanks again for the patch 👍 We plan to release gsDesign 3.6.1 to CRAN this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants