Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break gMCPLite. The culprit of the breakage is that we have made the
name
argument of scales the first, see tidyverse/ggplot2#5583.Given that there are some overlapping contributors/authors, I can disclose that this essentially repeats Merck/gMCPLite#25 for the same reason, but for gsDesign. I noticed the deprecation warnings about the
gsDesign::hGraph()
function in favour of the gMCPLite one, but decided that the courteous thing to do is to put in a seperate PR anyway.To test the code changes with the release candidate, you can install it with the code below:
The release of ggplot2 3.5.0 is scheduled at the end of January / early Februari. The progress can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help gsDesign get out a fix if necessary.
Please, feel entirely free to close this PR if
gMCPLite::hGraph()
will replacegsDesign::hGraph()
.