Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring - application, baseWriter #47

Merged
merged 22 commits into from
Feb 9, 2024
Merged

refactoring - application, baseWriter #47

merged 22 commits into from
Feb 9, 2024

Conversation

ondrajodas
Copy link
Contributor

@ondrajodas ondrajodas commented Oct 22, 2023 •
edited
Loading

AdamVyborny
AdamVyborny reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@AdamVyborny AdamVyborny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zase jen pár drobností...

composer.json Outdated Show resolved Hide resolved
src/Validator.php Outdated Show resolved Hide resolved
src/Writer/BaseWriter.php Show resolved Hide resolved
tests/functional/PdoTestConnection.php Outdated Show resolved Hide resolved
@ondrajodas ondrajodas marked this pull request as ready for review February 8, 2024 12:10
AdamVyborny
AdamVyborny requested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@AdamVyborny AdamVyborny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ještě ten composer.phar v README asi už není aktuální, ne?

@ondrajodas
Copy link
Contributor Author

jo trochu jsem to přepsal to README

AdamVyborny
AdamVyborny approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@AdamVyborny AdamVyborny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ondrajodas ondrajodas merged commit e53a835 into master Feb 9, 2024
1 check passed
@ondrajodas ondrajodas deleted the ondra-refactoring branch February 9, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamVyborny AdamVyborny AdamVyborny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ondrajodas @AdamVyborny