UI events #3
Merged
UI events #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfejfar
requested changes
May 30, 2022
There was a problem hiding this comment.
Šlo by to prosím rebasnout nad #2 a přidat tam ty testovací eventy?
|
Jo tak počkám a pak na to mrknu. |
|
Přidal jsem testovácí eventy. Ještě jsem vyhodil event na kopírování row. Protože to sice na UI načítáme ale přitom je to na UI zakázáno. A pokud se to nebude povolovat, tak bych byl spíše pro to vyhodit z UI. Ještě se na to ptám - https://keboola.slack.com/archives/C02C3GZUS/p1653996756698229 |
tomasfejfar
approved these changes
May 31, 2022
|
Klidně bych byl pro to mergnout a ten event přidal v nějakém dalším PR, pokud bude potřeba. |
|
Fajn, případně doladíme, díky za check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toto by mělo být snad vše - je to vše pouze pro ty activity/last edits na dashboard.
Ještě tam máme tu eventu z CLI, ale to posílal Michal - https://github.com/keboola/event-schema/blob/main/schema/ext.keboola.keboola-as-code..json.
Tam čteme pouze
messagesnad na UI.