adds icons & compilation script #145

janmichek · 2018-04-30T11:04:54Z

Fixes #144

janmichek · 2018-04-30T13:03:37Z

@ujovlado muzes mi pls poradit proc neprochazi test? Na lokalu vse ok, nedokazu potvrdit umisteni spritu na serveru. Snazil jsem se jeste tu kompilaci explicitne uvest do build scriptu, ale zrejme to ten soubor fakt nevidi. f7c2df3

ujovlado · 2018-05-02T14:34:11Z

No nevie to najst ten subor s ikonkami:

FAIL  src/indigo/components/AlertBlock.test.js
  ● Test suite failed to run
    Cannot find module '../../../public/icons/symbol/svg/sprite.symbol.svg' from 'Icon.jsx'
      
      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:179:17)
      at Object.<anonymous> (src/indigo/components/Icon.jsx:2:21)

janmichek · 2018-05-02T14:39:12Z

CHapu, v tom pripade musi byt nejaka chyba na serverovy casti. Na lokale mi to slo, na soubory na serveru nevidim

ujovlado · 2018-05-02T14:39:25Z

src/indigo/components/Icon.jsx

@@ -0,0 +1,20 @@
+import React from 'react';
+import IconSprite from '../../../public/icons/symbol/svg/sprite.symbol.svg';


tato cesta je ale 100% zle

ujovlado · 2018-05-02T14:55:53Z

@janmichek neozrejmil by si trosku, co chces dosiahnut? Chces distribuovat len ten sprite alebo aj ostatne svg ikonky? Kazdopadne ta cesta k tomu sprite nemoze byt z public foldra.

janmichek · 2018-05-02T15:03:16Z

Snazim se pristoupit k tomu spritu - ty jednotlivy ikonky jsou mi jedno

ujovlado · 2018-05-02T15:08:11Z

No a keby sme zaverzovali aj ten sprite? Alebo ako casto sa to bude menit?

janmichek · 2018-05-02T15:10:11Z

Klido, muze byt. Nebude se to menit casto, a pokud jo, tak bude duvod to odverzovat

ujovlado · 2018-05-02T15:11:42Z

Rozmyslam nad tym takto:

v src/icons by boli vsetky ikonky
bezal by dev task + watch na tieto ikonky
akonahle nieco zmenis tak by sa to pregenerovalo do src/indigo/img/icons-sprite.svg
potom by sa to normlane commitlo (tu je ale maly priestor na chybu ak to clovek zabudne)
linkoval by si to odtial (src/indigo/img/icons-sprite.svg)

janmichek · 2018-05-02T15:14:33Z

Chapu, pokud to neumime udelat ciste na serveru, tak asi nezbyva nez to udelat takhle, jak pises.

ujovlado · 2018-05-02T16:33:10Z

Skusil by si to teda upravit? To commitovanie sa mi ale celkom pozdava, lebo je tam lepsia moznost vizulanej kontroly ako na CI (kde je ziadna).

Nie je tam problem "na serveru", len to treba generovat do spravnej cesty.

janmichek · 2018-05-03T11:05:25Z

@ujovlado jsem se v tom nejak ztratil, nejde mi updatnout ten test pomoci 'yarn jest -u', jak to fungovalo predtim. Nebo nerozumim tomu co delam blbe. VYpada to ze to svgcko se mu nelibi

ujovlado · 2018-05-03T21:00:54Z

@janmichek pofixoval som ti to ... este ale prosim pridaj test (+snapshoty) na Icon komponentu a kukni komentare, co som pridal

ujovlado · 2018-05-03T21:01:55Z

src/indigo/components/Icon.jsx

+import IconSprite from './../img/symbol/svg/sprite.symbol.svg';
+
+export default React.createClass({
+    displayName: 'Icon',


displayName nie je potrebne

ujovlado · 2018-05-03T21:02:48Z

src/indigo/components/Icon.jsx

+        iconClass: React.PropTypes.string,
+        className: React.PropTypes.string,
+    },
+    getAdditionalClasses: function () {


toto prosim zahod a zamen za pouzitie classnames (kukni ine komponenty, napr. Loader)

ujovlado · 2018-05-03T21:03:18Z

src/indigo/components/Icon.jsx

+export default React.createClass({
+    displayName: 'Icon',
+    propTypes: {
+        iconClass: React.PropTypes.string,


nemalo by byt iconClass required?

ujovlado · 2018-05-03T21:05:34Z

tie snapshoty pre Icon bude stacit pred 2-3 ikonky, len pre istotu.

janmichek · 2018-05-07T09:24:32Z

@ujovlado fixed

ujovlado · 2018-05-09T10:31:08Z

Este tie snapshoty pls #145 (comment)

janmichek · 2018-05-09T10:46:20Z

Ok, diky. Hele ja si vubec nevim na co ty snapshoty jsou. Myslel jsem ze staci pred kazdym pushem spustit 'yarn jest -u'. Zrejme nevim k cemu to slouzi, a potrebuju se to doucit. Failuje mi to na stejny chybe jako predtim #145 (comment) -> nemuze to najit soubor s svg. Predpokladam, ze se mam ponorit do dokumentace Jestu. https://facebook.github.io/jest/

ujovlado · 2018-05-09T10:51:19Z

To neviem uplne, kde si sa docital, ze to treba pred kazdym pushom pustit. Imho je to blbost, potom by tie snapshoty fakt nemali vyznam.

Snapshoty su na to, aby sme zarucili, ze sa pri upravach nezmeni "markup" tej komponenty - urobime jej snapshot. Ked sa nejakou zmenou stane, ze nesedi snapshot - zacne failovat test a vieme, ze sa nieco zmenilo.

To moze mat vyhody napr. vtedy ked budeme mat komponenty viac previazane a pod. A tiez napr. ked bude indigo pouzite vo viac projektoch.

T.j. cele pointa je v tom mat tie komponenty stabilne.

ujovlado · 2018-05-09T10:51:44Z

Kde ti to presne failuje? Pretoze vidim, ze posledny check presiel. https://travis-ci.org/keboola/indigo-ui/builds/375805058?utm_source=github_status&utm_medium=notification

janmichek · 2018-05-10T15:50:15Z

Pridal jsem test pro Icon.
Ten test samozrejme neprochazi, protoze jsem nevytvoril snapshot.
Snapshot mi nejde vytvorit. hazi mi to tuhle chybu. Vypada to ze tomu testu se nelibi, ze zcatek svg souboru zacina znakem '<'. Vubec nevim, zkusim to progooglit

FAIL src\indigo\components\Icon.test.js
● Test suite failed to run

D:\DEV\KEBOOLA\indigo-ui\src\indigo\img\symbol\svg\sprite.symbol.svg:1
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){<?xml version="1.0" encoding="

UTF-8"?><symbol viewBox="-1 -1 12 8

SyntaxError: Unexpected token <

  at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/ScriptTransformer.js:289:17)
  at Object.<anonymous> (src/indigo/components/Icon.jsx:2:21)
  at Object.<anonymous> (src/indigo/components/Icon.test.js:4:13)

janmichek · 2018-05-10T16:46:04Z

Resi s to tady, uz jsem zkousel nejaky fixy, ale jeste jsem neprojel vse jestjs/jest#2663

ujovlado · 2018-05-10T17:00:59Z

ok, skusim na to tiez pozriet, ked je to take zapeklite ;)

janmichek · 2018-05-14T10:19:30Z

errory z konzole fixed

ujovlado · 2018-05-14T10:50:12Z

Tak ak to blbne "len" u teba asi by som to neriesil. Ako vidis, na Travise to prechadza.

ujovlado · 2018-05-14T10:50:29Z

Co mi este napada, ak mas Docker, ci to neskusis tak.

ujovlado · 2018-05-14T10:50:55Z

Inac to tu asi este raz skontrolujem a myslim, ze je to ready na merge.

janmichek · 2018-05-14T11:09:52Z

ahaak, dobrej tip. Navzdory ocekavani, mi ten test spusteny v dockeru neprojde ./ Myslim ze mi zatim bude stacit spousteni testu na Travisu, jako workaround.

ujovlado · 2018-05-14T11:17:37Z

tvl, skoda, ze to nepomohlo ... ak mi to napadne, skusim to ked budem nieco riesit na windowsoch

ujovlado reviewed May 2, 2018

View reviewed changes

ujovlado force-pushed the jan-svg-icons branch 2 times, most recently from 6fbf86a to d57c6fa Compare May 3, 2018 20:55

ujovlado reviewed May 3, 2018

View reviewed changes

janmichek changed the title ~~WIP: adds icons & compilation script~~ adds icons & compilation script May 7, 2018

ujovlado force-pushed the jan-svg-icons branch from 308ba19 to 44a8ef6 Compare May 10, 2018 07:03

ujovlado force-pushed the jan-svg-icons branch from c97113c to 7c59355 Compare May 10, 2018 19:29

Jan Michek and others added 20 commits May 15, 2018 08:59

adds icons & compilation script

2ce6742

fixes icon naming

eb4a40e

replaces img to icon solution

8a90c93

updates server build script

06bcb08

fixes path to icon set

f6c0a8e

fixes compilation paths

9ac3f49

Remove unused section from Gruntfile

370fbb5

Enable logging

83c363f

Rename target for svg_sprite

ab3a377

Update snapshots

4c0212c

Add generated sprite

c5740ee

Fix icons watching task

6dd4531

Fix CS

029671d

removes unused property

0010f67

simplifies adding classnames to component

23d2c39

adds required condition

314de3f

adds Icon test

8d25ce5

Refactor Icon component

228a4f6

Add snapshots for Icon component

1e0071f

updates storybook markup

89b9114

ujovlado force-pushed the jan-svg-icons branch from 773ba53 to 89b9114 Compare May 15, 2018 07:12

ujovlado merged commit 6d0a99f into master May 15, 2018

ujovlado deleted the jan-svg-icons branch May 15, 2018 07:25

ujovlado mentioned this pull request Aug 1, 2018

Use new version of font-awesome? #226

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds icons & compilation script #145

adds icons & compilation script #145

janmichek commented Apr 30, 2018

janmichek commented Apr 30, 2018

ujovlado commented May 2, 2018

janmichek commented May 2, 2018

ujovlado May 2, 2018

ujovlado commented May 2, 2018

janmichek commented May 2, 2018

ujovlado commented May 2, 2018

janmichek commented May 2, 2018

ujovlado commented May 2, 2018 •

edited

janmichek commented May 2, 2018

ujovlado commented May 2, 2018

janmichek commented May 3, 2018

ujovlado commented May 3, 2018

ujovlado May 3, 2018

ujovlado May 3, 2018

ujovlado May 3, 2018

ujovlado commented May 3, 2018

janmichek commented May 7, 2018

ujovlado commented May 9, 2018

janmichek commented May 9, 2018

ujovlado commented May 9, 2018

ujovlado commented May 9, 2018 •

edited

janmichek commented May 10, 2018

janmichek commented May 10, 2018

ujovlado commented May 10, 2018

janmichek commented May 14, 2018

ujovlado commented May 14, 2018

ujovlado commented May 14, 2018

ujovlado commented May 14, 2018

janmichek commented May 14, 2018

ujovlado commented May 14, 2018

		@@ -0,0 +1,20 @@
		import React from 'react';
		import IconSprite from '../../../public/icons/symbol/svg/sprite.symbol.svg';

adds icons & compilation script #145

adds icons & compilation script #145

Conversation

janmichek commented Apr 30, 2018

janmichek commented Apr 30, 2018

ujovlado commented May 2, 2018

janmichek commented May 2, 2018

ujovlado May 2, 2018

Choose a reason for hiding this comment

ujovlado commented May 2, 2018

janmichek commented May 2, 2018

ujovlado commented May 2, 2018

janmichek commented May 2, 2018

ujovlado commented May 2, 2018 • edited

janmichek commented May 2, 2018

ujovlado commented May 2, 2018

janmichek commented May 3, 2018

ujovlado commented May 3, 2018

ujovlado May 3, 2018

Choose a reason for hiding this comment

ujovlado May 3, 2018

Choose a reason for hiding this comment

ujovlado May 3, 2018

Choose a reason for hiding this comment

ujovlado commented May 3, 2018

janmichek commented May 7, 2018

ujovlado commented May 9, 2018

janmichek commented May 9, 2018

ujovlado commented May 9, 2018

ujovlado commented May 9, 2018 • edited

janmichek commented May 10, 2018

janmichek commented May 10, 2018

ujovlado commented May 10, 2018

janmichek commented May 14, 2018

ujovlado commented May 14, 2018

ujovlado commented May 14, 2018

ujovlado commented May 14, 2018

janmichek commented May 14, 2018

ujovlado commented May 14, 2018

ujovlado commented May 2, 2018 •

edited

ujovlado commented May 9, 2018 •

edited