CT-1386 - backend configuration provider

keboola · Apr 24, 2024 · bbf1302 · bbf1302
1 parent 5d6ffe4
commit bbf1302
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 31 deletions.
diff --git a/tests/BackendConfigurationProviderTrait.php b/tests/BackendConfigurationProviderTrait.php
@@ -0,0 +1,19 @@
+<?php declare(strict_types=1);
+
+namespace Keboola\ManageApiTest;
+
+trait BackendConfigurationProviderTrait
+{
+    public function getSnowflakeBackendCreateOptions(): array
+    {
+        return [
+            'backend' => 'snowflake',
+            'host' => getenv('KBC_TEST_SNOWFLAKE_HOST'),
+            'warehouse' => getenv('KBC_TEST_SNOWFLAKE_WAREHOUSE'),
+            'username' => getenv('KBC_TEST_SNOWFLAKE_BACKEND_NAME'),
+            'password' => getenv('KBC_TEST_SNOWFLAKE_BACKEND_PASSWORD'),
+            'region' => getenv('KBC_TEST_SNOWFLAKE_BACKEND_REGION'),
+            'owner' => 'keboola',
+        ];
+    }
+}
diff --git a/tests/ProjectStorageBackendTest.php b/tests/ProjectStorageBackendTest.php
@@ -10,6 +10,8 @@
 
 class ProjectStorageBackendTest extends ClientTestCase
 {
+    use BackendConfigurationProviderTrait;
+
     public function supportedNonDefaultBackends(): array
     {
         return [
@@ -127,7 +129,7 @@ public function testProjectStorageAssignBackendFailedWithNonNumericBackendId():
         }
 
         $this->client->removeProjectStorageBackend($project['id'], $project['backends']['snowflake']['id']);
-        $backend = $this->client->createStorageBackend($this->getBackendCreateOptions());
+        $backend = $this->client->createStorageBackend($this->getSnowflakeBackendCreateOptions());
 
         // ensure, that backend ID is passed as string into body
         $requestOptions['body'] = '{"storageBackendId": "'.$backend['id'].'"}';
@@ -138,19 +140,6 @@ public function testProjectStorageAssignBackendFailedWithNonNumericBackendId():
         $this->client->purgeDeletedProject($project['id']);
     }
 
-    public function getBackendCreateOptions(): array
-    {
-        return [
-            'backend' => 'snowflake',
-            'host' => getenv('KBC_TEST_SNOWFLAKE_HOST'),
-            'warehouse' => getenv('KBC_TEST_SNOWFLAKE_WAREHOUSE'),
-            'username' => getenv('KBC_TEST_SNOWFLAKE_BACKEND_NAME'),
-            'password' => getenv('KBC_TEST_SNOWFLAKE_BACKEND_PASSWORD'),
-            'region' => getenv('KBC_TEST_SNOWFLAKE_BACKEND_REGION'),
-            'owner' => 'keboola',
-        ];
-    }
-
     public function testStorageBackendRemove()
     {
         $name = 'My org';

diff --git a/tests/StorageBackendTest.php b/tests/StorageBackendTest.php
@@ -8,14 +8,16 @@
 
 class StorageBackendTest extends ClientTestCase
 {
+    use BackendConfigurationProviderTrait;
+
     public function testOnlySuperadminCanRegisterStorageBackend(): void
     {
-        $newBackend = $this->client->createStorageBackend($this->getBackendCreateOptions());
+        $newBackend = $this->client->createStorageBackend($this->getSnowflakeBackendCreateOptions());
         $this->assertSame($newBackend['backend'], 'snowflake');
         $this->assertBackendExist($newBackend['id']);
         $this->client->removeStorageBackend($newBackend['id']);
 
-        $newBackend = $this->normalUserClient->createStorageBackend($this->getBackendCreateOptions());
+        $newBackend = $this->normalUserClient->createStorageBackend($this->getSnowflakeBackendCreateOptions());
         $this->assertSame($newBackend['backend'], 'snowflake');
         $this->assertBackendExist($newBackend['id']);
         $this->client->removeStorageBackend($newBackend['id']);
@@ -127,7 +129,7 @@ public function testCreateStorageBackend(array $options)
     public function storageBackendOptionsProvider(): iterable
     {
         yield 'snowflake' => [
-            $this->getBackendCreateOptions(),
+            $this->getSnowflakeBackendCreateOptions(),
         ];
         yield 'snowflake with dynamic backends' => [
             $this->getBackendCreateOptionsWithDynamicBackends(),
@@ -136,7 +138,7 @@ public function storageBackendOptionsProvider(): iterable
 
     public function storageBackendOptionsProviderForUpdate(): iterable
     {
-        $create = $this->getBackendCreateOptions();
+        $create = $this->getSnowflakeBackendCreateOptions();
         yield 'snowflake update password' => [
             $create,
             [
@@ -273,19 +275,6 @@ private function assertBackendNotExist(int $backendId): void
         $this->assertFalse($hasBackend);
     }
 
-    public function getBackendCreateOptions(): array
-    {
-        return [
-            'backend' => 'snowflake',
-            'host' => getenv('KBC_TEST_SNOWFLAKE_HOST'),
-            'warehouse' => getenv('KBC_TEST_SNOWFLAKE_WAREHOUSE'),
-            'username' => getenv('KBC_TEST_SNOWFLAKE_BACKEND_NAME'),
-            'password' => getenv('KBC_TEST_SNOWFLAKE_BACKEND_PASSWORD'),
-            'region' => getenv('KBC_TEST_SNOWFLAKE_BACKEND_REGION'),
-            'owner' => 'keboola',
-        ];
-    }
-
     public function getBackendCreateOptionsWithDynamicBackends(): array
     {
         return [