Merge pull request #240 from keboola/martinj-ct-992-allow-file-storag…

…e-registration-for-standard-user

CT-992 allow file storage registration for standard user

apiary.apib

@@ -3533,6 +3533,8 @@ Each type of storage has its own endpoint.
 
 ### Create new AWS S3 Storage [POST]
 
+Superuser credentials are not required for storage registration
+
 New S3 file Storage will be registered. Provided AWS credentials are verified and required permissions are validated.
 The Storage region is automatically detected.
 
@@ -3580,6 +3582,8 @@ Only storage owned by **keboola** can be set as default.
 
 ### Create new Google Cloud Storage [POST]
 
+Superuser credentials are not required for storage registration
+
 Will register new Google Cloud Storage for using inside KBC. Connection wil be verified during registraion.
 
 + Request (application/json)
@@ -3612,6 +3616,8 @@ Returns all registered Google Cloud Storages.
 
 ### Create new Azure Blob Storage [POST]
 
+Superuser credentials are not required for storage registration
+
 Will register new Azure Blob Storage for using inside KBC. Connection wil be verified during registraion.
 
 + Request (application/json)

tests/FileStorageGcsTest.php

@@ -208,4 +208,18 @@ public function testCrossProviderStorageCredentialsRotateGcsS3()
         $this->expectExceptionMessage(sprintf('AWS S3 file storage "%d" not found', $storage['id']));
         $this->client->rotateS3FileStorageCredentials($storage['id'], self::ROTATE_S3_OPTIONS);
     }
+
+    public function testNonSuperAdminFileStorageGcsCreate(): void
+    {
+        $storage = $this->normalUserClient->createGcsFileStorage($this->getGcsDefaultOptions());
+
+        $credentials = $storage['gcsCredentials'];
+        $this->assertArrayNotHasKey('private_key', $credentials);
+        $this->assertSame($this->getExpectedGcsCredentialsWithoutPk(), $credentials);
+        $this->assertSame('keboola', $storage['owner']);
+        $this->assertSame(TEST_GCS_REGION, $storage['region']);
+        $this->assertSame($storage['provider'], 'gcp');
+        $this->assertFalse($storage['isDefault']);
+        $this->assertStringEndsWith('_' . $storage['id'] . '_GCS', $storage['gcsSnowflakeIntegrationName']);
+    }
 }