Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT-1354 manage api setup automation #239

Merged
merged 18 commits into from
Apr 16, 2024

Conversation

martinjandl
Copy link
Contributor

@martinjandl martinjandl commented Apr 5, 2024

Jira: CT-1354
Connection PR: XXXXX

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • Apiary file is updated
  • You declared if there is a BC break or not (will affect next release of a client)

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

@martinjandl martinjandl added the no release just test changes label Apr 5, 2024
@martinjandl martinjandl requested review from a team, vojtabiberle and jirkasemmler and removed request for a team and vojtabiberle April 5, 2024 06:10
Copy link
Contributor

@jirkasemmler jirkasemmler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

par malickosti, zejmena naming

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jirkasemmler jirkasemmler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jeste jsem si tam vsiml jedne malickosti, tak na to prosim mrkni. jinak ok a frci to

@martinjandl martinjandl force-pushed the martinj-ct-1354-manage-api-setup-automation branch from 387113d to 2048824 Compare April 16, 2024 14:58
@martinjandl martinjandl merged commit 17828e4 into master Apr 16, 2024
3 checks passed
@martinjandl martinjandl deleted the martinj-ct-1354-manage-api-setup-automation branch April 16, 2024 16:20
TEST_GCS_REGION=
KBC_MANAGE_API_SUPER_TOKEN_WITH_UI_MANAGE_SCOPE=super_token_with_ui_manage_scope # can be created in manage-apps on the Tokens tab. Token must have "ui manage" scope
KBC_TEST_MAINTAINER_ID=id # `id` of maintainer. Please create a new maintainer dedicated to test suite. All maintainer's organizations and projects all purged before tests!
KBC_TEST_ADMIN_EMAIL=email_of_another_admin_having_mfa_disabled # email address of another user without any organizations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KBC_TEST_ADMIN_EMAIL=devel-tests+test_admin@keboola.com

Would work as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no release just test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants