Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT-1402 fix2 token management endpoint #252

Merged
merged 3 commits into from
May 14, 2024
Merged

CT-1402 fix2 token management endpoint #252

merged 3 commits into from
May 14, 2024

Conversation

vojtabiberle
Copy link
Contributor

@vojtabiberle vojtabiberle commented May 12, 2024 •
edited

Jira: CT-1402
Connection PR: https://github.com/keboola/connection/pull/5052

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • Apiary file is updated
  • You declared if there is a BC break or not (will affect next release of a client)

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

@vojtabiberle vojtabiberle added the no release just test changes label May 12, 2024
@vojtabiberle vojtabiberle force-pushed the vb-CT1402-fix2-token-management-endpoint branch from d1facbc to 43e9736 Compare May 12, 2024 20:18
tomasfejfar
tomasfejfar requested changes May 13, 2024
View reviewed changes
openapi.yml Show resolved Hide resolved
tests/ProjectsTest.php Outdated Show resolved Hide resolved
@tomasfejfar tomasfejfar self-requested a review May 13, 2024 12:09
@vojtabiberle vojtabiberle merged commit ec54675 into master May 14, 2024
3 checks passed
@vojtabiberle vojtabiberle deleted the vb-CT1402-fix2-token-management-endpoint branch May 14, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasfejfar tomasfejfar tomasfejfar approved these changes

Assignees
No one assigned
Labels
no release just test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vojtabiberle @tomasfejfar