Skip to content

Commit

Permalink
Remove rule RequireTrailingCommaInDeclarationSniff because of PHP 7.4…
Browse files Browse the repository at this point in the history
… requirement
  • Loading branch information
AdamVyborny committed May 6, 2024
1 parent fb5692a commit 798be0e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion phpcs.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<exclude name="SlevomatCodingStandard.TypeHints.ParameterTypeHint"/>
<exclude name="SlevomatCodingStandard.TypeHints.PropertyTypeHint"/>
<exclude name="SlevomatCodingStandard.TypeHints.ReturnTypeHint"/>
<exclude name="SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration"/>
</rule>
<exclude-pattern>*/src/Kernel.php</exclude-pattern>
</ruleset>
</ruleset>
2 changes: 1 addition & 1 deletion src/Config/BaseConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class BaseConfig implements ConfigInterface
*/
public function __construct(
array $config,
?ConfigurationInterface $configDefinition = null,
?ConfigurationInterface $configDefinition = null
) {
$this->setConfigDefinition($configDefinition);
$this->setConfig($config);
Expand Down
4 changes: 2 additions & 2 deletions src/Manifest/ManifestManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class ManifestManager
private string $dataDir;

public function __construct(
string $dataDir,
string $dataDir
) {
$this->dataDir = $dataDir;
}
Expand All @@ -36,7 +36,7 @@ final public function getManifestFilename(string $fileName): string

public function writeFileManifest(
string $fileName,
OutFileManifestOptions $options,
OutFileManifestOptions $options
): void {
$tableManifestName = $this->getManifestFilename($fileName);
$this->internalWriteFileManifest($tableManifestName, $options->toArray());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function __construct(
bool $nullable = true,
bool $primaryKey = false,
?string $description = null,
array $metadata = [],
array $metadata = []
) {
$this->setName($name);
$this->setDataType($dataTypes);
Expand Down

0 comments on commit 798be0e

Please sign in to comment.