Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new interface for escaping strings and synapse implementation #21

Merged
merged 1 commit into from
May 10, 2021

Conversation

zajca
Copy link
Member

@zajca zajca commented May 10, 2021

It's supper annoying injecting always doctrine connection to get platform and be able to quote.

  • new Keboola\TableBackendUtils\Escaping\QuoteInterface::{quote,quoteSingleIdentifier} naming is same as in doctrine

@zajca zajca requested a review from a team May 10, 2021 11:59
Copy link
Contributor

@ErikZigo ErikZigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zajca zajca merged commit 48ca30d into master May 10, 2021
@zajca zajca deleted the zajca-escaping branch May 10, 2021 12:25
@zajca zajca mentioned this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants