Added method setBoundaries #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaljurecko
commented
Dec 11, 2020
| @@ -102,7 +102,8 @@ class SqlFormatter | |||
| ); | |||
|
|
|||
| // Punctuation that can be used as a boundary between other tokens | |||
| protected static $boundaries = array(',', ';',':', ')', '(', '.', '=', '<', '>', '+', '-', '*', '/', '!', '^', '%', '|', '&', '#'); | |||
| const DEFAULT_BOUNDARIES = array(',', ';',':', ')', '(', '.', '=', '<', '>', '+', '-', '*', '/', '!', '^', '%', '|', '&', '#'); | |||
There was a problem hiding this comment.
v PHP 5.6 nemoze byt public const.
| public static function setBoundaries(array $boundaries) | ||
| { | ||
| self::$boundaries = $boundaries; | ||
| self::$regex_boundaries = '('.implode('|',array_map(array(__CLASS__, 'quote_regex'),self::$boundaries)).')'; |
There was a problem hiding this comment.
Pri zmene tychto vyhradenych znakov, je potrebne upravit aj regexp.
| @@ -122,7 +123,7 @@ public function testSynapseTempTables() { | |||
| $sqlWithComment = "-- This is comment\n" . $sql; | |||
| $expected = <<<SQL | |||
| SELECT | |||
| * INTO # temp_table | |||
| * INTO #temp_table | |||
There was a problem hiding this comment.
Prehliadol som, ze mi to tu pridava medzeru, co je nespravne.
|
@ondrajodas mozes prosim pozriet este tento fix, nevsimol som si to |
|
@Webrouse jj jdu na to |
ondrajodas
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://keboola.atlassian.net/browse/COM-570