Add support to set KEDA_HTTP_DEFAULT_TIMEOUT in metrics server
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
JorTurFer
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
JorTurFer
changed the title
KEDA_HTTP_DEFAULT_TIMEOUT in metrics server
4 tasks
tomkerkhove
approved these changes
Aug 30, 2021
do you mean all the changes but |
|
Yes, thank you! |
|
sure! :) |
|
Done! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to set
KEDA_HTTP_DEFAULT_TIMEOUTin metrics-server by the same way that we are using for the operator.I have created the PR following these steps, https://github.com/kedacore/charts/blob/master/CONTRIBUTING.md. Let me know if it's correct or I have to do/undo anything else :)
Checklist
KEDA_HTTP_DEFAULT_TIMEOUTkeda#2062Fixes #180