Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use .Values.serviceAccount.name for rolebinding #190

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

fivesheep
Copy link
Contributor

@fivesheep fivesheep commented Oct 30, 2021

Signed-off-by: Xiayang Wu xwu@rippling.com

Provide a description of what has been changed

For #189
The rolebindings did not use the serviceAccount.name, and the helmchart will only work when setting serviceAccount.name same as operator.name, which is not always the case

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Fixes #

Signed-off-by: Xiayang Wu <xwu@rippling.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants