Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for metricRelabelings to Pod and Service monitors #603

Merged
merged 2 commits into from
Jan 29, 2024
Merged

feat: Add support for metricRelabelings to Pod and Service monitors #603

merged 2 commits into from
Jan 29, 2024

Conversation

pragmaticivan
Copy link
Contributor

Add support for metricRelabelings to Pod and Service monitors.
Ref: https://www.robustperception.io/relabel_configs-vs-metric_relabel_configs/

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #514

@pragmaticivan
Add support for metricRelabelings to Pod and Service monitors
4ae9f12 
Signed-off-by: Ivan Santos <301291+pragmaticivan@users.noreply.github.com>
@pragmaticivan pragmaticivan requested a review from a team as a code owner January 27, 2024 17:57
@pragmaticivan pragmaticivan changed the title Add support for metricRelabelings to Pod and Service monitors feat: Add support for metricRelabelings to Pod and Service monitors Jan 27, 2024
@JorTurFer
Copy link
Member

Nice improvement!
Could you update docs as well? https://github.com/kedacore/charts/blob/main/CONTRIBUTING.md#documentation

@pragmaticivan
doc: update docs
a0ac73a 
Signed-off-by: Ivan Santos <301291+pragmaticivan@users.noreply.github.com>
@pragmaticivan
Copy link
Contributor Author

Nice improvement! Could you update docs as well? https://github.com/kedacore/charts/blob/main/CONTRIBUTING.md#documentation

Done! Sorry, for some reason I thought it was done after the merge on release time.

@JorTurFer JorTurFer merged commit 6493bd1 into kedacore:main Jan 29, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for metricRelabelings to Pod and Service monitors
2 participants
@pragmaticivan @JorTurFer