Enlist Cosmos DB scaler on Artifact Hub #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkerkhove
requested changes
Nov 10, 2021
|
Can you also provide the This should help them install the external scaler. Example: https://artifacthub.io/packages/keptn/keptn-integrations/dynatrace-service?modal=install (source) |
|
Marked PR as draft. I will get the release created and Helm chart ready for the external scaler before working on this one. |
|
Feel free to let me know if you need help here @JatinSanghvi (but take your time) |
JatinSanghvi
force-pushed
the
JatinSanghvi-enlist-cosmosdb-scaler
branch
from
1ef5b7d
to
c10ed0e
Compare
JatinSanghvi
force-pushed
the
JatinSanghvi-enlist-cosmosdb-scaler
branch
2 times, most recently
from
46ff9ca
to
a077598
Compare
tomkerkhove
reviewed
Nov 22, 2021
There was a problem hiding this comment.
LGTM, but let's wait for kedacore/external-scaler-azure-cosmos-db#20 & kedacore/charts#203
Signed-off-by: Jatin Sanghvi <20547963+JatinSanghvi@users.noreply.github.com>
Signed-off-by: Jatin Sanghvi <20547963+JatinSanghvi@users.noreply.github.com>
Signed-off-by: Jatin Sanghvi <20547963+JatinSanghvi@users.noreply.github.com>
JatinSanghvi
force-pushed
the
JatinSanghvi-enlist-cosmosdb-scaler
branch
from
704946e
to
7bfef81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added package for 'KEDA external scaler for Azure Cosmos DB' in 'KEDA Official External Scalers' repository on Artifact Hub.
Checklist
Fixes kedacore/external-scaler-azure-cosmos-db#7