Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an ingress controller #10

Closed
arschles opened this issue Jan 27, 2021 · 3 comments
Closed

Use an ingress controller #10

arschles opened this issue Jan 27, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers traffic-sources All issues related to where HTTP traffic can come from
Milestone

Comments

@arschles
Copy link
Collaborator

arschles commented Jan 27, 2021

Instead of creating a Service with type: LoadBalancer on it for the interceptors, use a single ingress controller (it should be installed by the helm chart) and create an Ingress for each new app.

Use-Case

Users should be able to use their existing ingress controller and have the operator integrate with it. Three use cases:

  • A user has a brand new, vanilla k8s cluster and wants to install an ingress controller. they helm install the chart and the operator spits out Ingress resources
  • A user has already installed the chart on their cluster and wants to reuse their existing ingress controller, so they helm install the chart and turn off the ingress controller option. the operator still spits out Ingress resources and the existing ingress controller picks them up properly
  • A user has a new k8s cluster on their cloud provider, which has a built-in ingress controller, so they helm install the chart and the operator spits out Ingress objects and the cloud provider ingress picks them up properly

Specification

  • The helm chart should deploy an ingress controller
    • Have the helm chart take a dependency on the nginx ingress controller chart
    • Allow users to override that dependency, or turn it off completely if they already have one
  • The operator should deploy Ingress objects
@arschles
Copy link
Collaborator Author

cc/ @khaosdoctor

@khaosdoctor
Copy link
Contributor

Needs #36 for the annotations, I'm on it after that because it'll need some changes on the CRD api

@tomkerkhove tomkerkhove added the traffic-sources All issues related to where HTTP traffic can come from label Feb 12, 2021
@arschles arschles added this to the Alpha 2 milestone Feb 24, 2021
@arschles arschles added the good first issue Good for newcomers label Feb 24, 2021
arschles added a commit to arschles/http-add-on that referenced this issue Feb 24, 2021
Fixes kedacore#10

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
Copy link
Collaborator Author

arschles commented Mar 9, 2021

closing, as this is out of scope. see #82

@arschles arschles closed this as completed Mar 9, 2021
kingdonb pushed a commit to kingdonb/http-add-on that referenced this issue Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers traffic-sources All issues related to where HTTP traffic can come from
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants