Move charts to keda/charts #125
Conversation
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
khaosdoctor
requested review from
ahmelsayed,
arschles,
tomkerkhove and
zroubalik
as code owners
|
@arschles @tomkerkhove I took the time to do this housekeeping tasks today, can you take a look at this? PR is kedacore/charts#137 |
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
There was a problem hiding this comment.
@khaosdoctor is there a corresponding PR in kedacore/charts?
Edit: sorry, I just saw your above comment. Just the one nitpick. I agree with @tomkerkhove that we should wait until kedacore/charts#137 is merged
There was a problem hiding this comment.
@khaosdoctor another thing (sorry I forgot this the first time!) - since it's just for an example walkthrough, let's leave the xkcd chart in here, and move it to examples/
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
|
Also @arschles could you please fix the conflicts? I don't have permissions |
There was a problem hiding this comment.
@khaosdoctor just one request. otherwise looks great, thanks 😄
Co-authored-by: Aaron Schlesinger <aaron@ecomaz.net> Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
There was a problem hiding this comment.
@khaosdoctor this looks great! thanks for sticking with it 🚀
let's wait for kedacore/charts#137 to be merged before merging this one. this also needs to get conflicts resolved before then
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Head branch was pushed to by a user without write access
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
|
They are merged on kedacore/charts. Feel free to remove them in this repo. |
|
@arschles I think this one got stuck |
|
@khaosdoctor CI is running hopefully one last time 😄 |
Moving charts from this repo to the official kedacore/charts repo
Checklist
Fixes #104