New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding configurability to the interceptor's HTTP round tripper #250

Merged

arschles merged 47 commits into kedacore:main from arschles:interceptor-config

Sep 22, 2021

Collaborator

arschles commented Sep 1, 2021 •

edited

Removing hard-coded values in the http round tripper's configuration in the interceptor, and replacing them with values that can be set via environment variables in the interceptor

This PR has been submitted as a draft because it relies on #206. It should not be reviewed or merged until that one it. It will be converted to a non-draft PR after that happens.

Update: #206 is merged and this PR is taken out of draft mode. It is ready for review.

Checklist

Commits are signed with Developer Certificate of Origin (DCO)
Any necessary documentation is added, such as:
Expose configs on helm chart

Fixes #248

arschles and others added 30 commits

August 18, 2021 15:05


          multi-tenant interceptor and scaler

43e8eff

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>


          Merge branch 'main' of github.com:kedacore/http-add-on into global-co…

cbe11ec

…mponents

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          Merge branch 'main' of github.com:kedacore/http-add-on into global-co…

7bb4e11

…mponents

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          specifying host in XKCD ingress

9d7fae6

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          routing the xkcd chart to the interceptor properly

e6a6d67

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          check host header first

20dac47

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          sending true active response in stream

a3c0403

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          passing target pending requests through to the underlying ScaledObjec…

ff8a3c0

…t (so the scaler can read it later)

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          removing broken target pending requests

ee8ef79

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          using getHost in proxy handler

966e8ce

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          adding integration test

b96f209

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          adding more tests to the integration test

1123c70

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          splitting up integration tests

013915e

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          more checks

f63ad32

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          mark new test TODO

37fe73b

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          expanding interceptor integration tests

6078beb

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          error messages

18452c3

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          refactor test

9b708e0

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          more test improvements

8db0df4

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          rolling back target pending requests in ScaledObject

647eaae

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          removing target metric error. it's not used anymore

3b34131

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          improving waitFunc test

9bda86e

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          Refactoring the deployment cache to add better error handing and resi…

76117d5

…lience.

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          adding doc comment

69d4c0f

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          refactoring deploy cache and adding tests

1039b92

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          Using interfaces for deployment watch & list

bebce95

this makes tests easier

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          adding more deploy cache tests

904b754

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          Fixing up TestK8sDeploymentCacheRewatch

0c1dd47

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          shutting down everything else when one thing errors, and adding a dep…

ae28597

…loyments cache endpoint

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          removing commented code

a083ac7

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>

arschles added 14 commits

August 24, 2021 12:51


          clarifying deployment cache JSON output, and simplifying deployment w…

a0dc40c

…atch function

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          adding TODO tests

15b46e8

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          error logs and restoring the count middleware

16762d0

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          using consistent net/http package name throughout main.go

3f32b2e

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          Refactoring deployment cache deployment storage

e316986

Also, running go mod tidy and adding new TODO (i.e. failing) tests

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          using deployment.Status.ReadyReplicas, instead of just replicas

33dd3f2

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          integration_tets ==> proxy_handlers_integration_test

1539e34

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          adding some resilience to tests

02abdb6

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          adding deployment cache endpoint documentation

db588d0

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          Merge branch 'main' of github.com:kedacore/http-add-on into global-co…

0bc461b

…mponents

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          running the global test target with sh.RunV

b45fd22

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          adding timeout to magefile test target

570e259

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          finishing one TODO test and adding issue for the rest:

0a3b321

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          Adding configurability to the interceptor's HTTP round tripper

2d21ac0

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>

arschles requested review from ahmelsayed, tomkerkhove and zroubalik as code owners

September 1, 2021 21:44

arschles marked this pull request as draft

September 1, 2021 21:44

arschles added 2 commits

September 7, 2021 11:42


          Merge branch 'main' of github.com:kedacore/http-add-on into intercept…

e496fdd

…or-config

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>


          fixing compile errs in tests

7ac0c82

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>

arschles marked this pull request as ready for review

September 7, 2021 20:40

Collaborator

ajanth97 commented Sep 8, 2021

Checked this. All good to be merged.

yaron2 approved these changes

View reviewed changes

yaron2 left a comment

lgtm

arschles enabled auto-merge (squash)

September 8, 2021 18:23


          Merge branch 'main' into interceptor-config

b07f9a1

arschles requested a review from ajanth97 as a code owner

September 21, 2021 23:28

ajanth97 approved these changes

View reviewed changes

Collaborator

ajanth97 left a comment

re-approving this.

arschles merged commit f8d7c0b into kedacore:main

arschles deleted the interceptor-config branch

September 22, 2021 16:14

Collaborator Author

arschles commented Sep 22, 2021

Thanks @ajanth97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yaron2 yaron2 approved these changes

ajanth97 ajanth97 approved these changes

ahmelsayed Awaiting requested review from ahmelsayed

tomkerkhove Awaiting requested review from tomkerkhove

zroubalik Awaiting requested review from zroubalik