Checking for deployment equality in deployment cache #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
arschles
requested review from
ahmelsayed,
ajanth97,
tomkerkhove and
zroubalik
as code owners
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
|
@ajanth97 what do you think? |
ajanth97
requested changes
Oct 8, 2021
pkg/k8s/deployment_cache.go
Outdated
| @@ -178,7 +206,8 @@ func (k *K8sDeploymentCache) addEvt(evt watch.Event) error { | |||
| "watch event did not contain a Deployment", | |||
| ) | |||
| } | |||
| k.latest[depl.GetObjectMeta().GetName()] = *depl | |||
| depl.GetName() | |||
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
|
thanks @bketelsen ! I really appreciate the review. even though the linkinator check is failing, I am going to merge this. the work to fix the links is being tracked in kedacore/keda#2215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the deployment cache sends the proper event type (
MODIFIEDorADDED) when it does periodic pings.Checklist
README.mddocs/directoryFixes #277