Adding test for 'interceptor' as host in GetScalerMetrics #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
arschles
requested review from
ahmelsayed,
ajanth97,
tomkerkhove and
zroubalik
as code owners
arschles
changed the title
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
|
Thanks @ajanth97! Even though the linkinator check is failing, I am going to merge this manually. The work to fix it is tracked in kedacore/keda#2215 and will be done separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for when
GetScalerMetricswas called with scaler metadata that hashost: "interceptor"Checklist
README.mddocs/directoryFixes #293
@ajanth97 since this follows up on #273, can you please take a look?