Fixing issue 271 #300
Merged
Fixing issue 271 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajanth97
requested review from
ahmelsayed,
arschles,
tomkerkhove and
zroubalik
as code owners
|
@arschles thank you for the suggestions. I will fix the DCO issue tomorrow |
Signed-off-by: Ajanth <ajanth1997@gmail.com>
kedacore#298) * chore: Provide configuration for automatically closing inactive issues Signed-off-by: GitHub <noreply@github.com> * Align with core Signed-off-by: GitHub <noreply@github.com> * feature instead of feature-request Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Ajanth <ajanth1997@gmail.com>
Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Signed-off-by: Ajanth <ajanth1997@gmail.com>
Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Signed-off-by: Ajanth <ajanth1997@gmail.com>
Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Signed-off-by: Ajanth <ajanth1997@gmail.com>
Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Signed-off-by: Ajanth <ajanth1997@gmail.com>
Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Signed-off-by: Ajanth <ajanth1997@gmail.com>
ajanth97
force-pushed
the
issue-271-fix-
branch
from
ee82b08
to
01c9683
Compare
|
@arschles thanks for the new suggestion too. Fixed the DCO issue |
arschles
requested changes
Oct 22, 2021
| } | ||
| newCM := routingConfigMap.DeepCopy() | ||
| if err := routing.SaveTableToConfigMap(table, newCM); err != nil { | ||
| lggr.Error(err, "couldn't save new routing table to ConfigMap", "configMap", routing.ConfigMapRoutingTableName) |
There was a problem hiding this comment.
@ajanth97 can you outdent this so it lines up with the line below?
|
It also looks like you'll need to fix a test: https://github.com/kedacore/http-add-on/runs/3977788275?check_suite_focus=true#step:4:75 |
Signed-off-by: Ajanth <ajanth1997@gmail.com>
Signed-off-by: Ajanth <ajanth1997@gmail.com>
arschles
approved these changes
Nov 5, 2021
|
Thanks for this @ajanth97! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ajanth ajanth1997@gmail.com
Provide a description of what has been changed
Checklist
README.mddocs/directoryFixes #271