Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing links to ghcr #301

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Fixing links to ghcr #301

merged 3 commits into from
Nov 9, 2021

Conversation

arschles
Copy link
Collaborator

Looks like the GH container registry links changed, and linkinator has been complaining about that. This PR fixes those.

Checklist

Fixes #

Signed-off-by: Aaron <aaron@ecomaz.net>
@arschles arschles added the documentation Improvements or additions to documentation label Oct 21, 2021
@arschles
Copy link
Collaborator Author

cc/ @tomkerkhove

@arschles
Copy link
Collaborator Author

Still looks like it's impossible to access the GH Container Registry pages for all KEDA containers if you're not logged in.

@arschles arschles enabled auto-merge (squash) October 21, 2021 21:28
@arschles
Copy link
Collaborator Author

arschles commented Nov 9, 2021

@tomkerkhove I have skipped checks on the https://ghcr.io links to the interceptor, operator and scaler in this PR, since they don't seem to be accessible without being logged into GitHub. Let me know if you figure out a fix for that.

@arschles arschles modified the milestones: v0.2.1, v0.2.0 Nov 9, 2021
@arschles arschles merged commit d2a1306 into kedacore:main Nov 9, 2021
@arschles arschles deleted the fix-pkgs-links branch November 9, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants