-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gh packages build workflow #40
Conversation
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Notes on why using docker action version 1.1.1 instead of v2: This is because the v2 splitted the jobs into three parts, now instead of using a single action, we'd have to use three actions, one for login, then another one for buildx and another one for qemu. It has become more robust and configurable, but for our use case it's too much. And besides, it has removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khaosdoctor can you change the helm charts as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments. Also, can you release a :latest
image in build_release.yml, in addition to the git SHA releases?
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment. Also, just reiterating, can you change the default docker images in the helm chart too?
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments, then I think this looks good.
Relevant links to set things up: |
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor thanks for making all the changes. I'm going to wait until I can get access to set up the container registry and required secrets from @tomkerkhove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created the secrets, but require a little change; sorry!
PACKAGES_USERNAME
-->GHCR_AUTH_USER
PACKAGES_PASSWORD
-->GHCR_AUTH_PAT
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
We would need to change this @khaosdoctor |
Sorry I didn't see this comment! |
Signed-off-by: Lucas Santos <hello@lsantos.dev>
@tomkerkhove done |
Adds the workflow files to enable CI
Checklist
Fixes #34