Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gh packages build workflow #40

Merged
merged 12 commits into from
Feb 5, 2021
Merged

Add gh packages build workflow #40

merged 12 commits into from
Feb 5, 2021

Conversation

khaosdoctor
Copy link
Contributor

Adds the workflow files to enable CI

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #34

Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor khaosdoctor marked this pull request as ready for review February 4, 2021 16:17
@khaosdoctor
Copy link
Contributor Author

Notes on why using docker action version 1.1.1 instead of v2:

This is because the v2 splitted the jobs into three parts, now instead of using a single action, we'd have to use three actions, one for login, then another one for buildx and another one for qemu. It has become more robust and configurable, but for our use case it's too much.

And besides, it has removed the tag_with_ref and tag_with_sha options, so we'd need to use other actions (or get those values manually).

Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khaosdoctor can you change the helm charts as well?

Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Also, can you release a :latest image in build_release.yml, in addition to the git SHA releases?

.github/workflows/build_release.yml Outdated Show resolved Hide resolved
.github/workflows/build_release.yml Outdated Show resolved Hide resolved
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Also, just reiterating, can you change the default docker images in the helm chart too?

.github/workflows/build_release.yml Show resolved Hide resolved
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, then I think this looks good.

.github/workflows/build_release.yml Outdated Show resolved Hide resolved
.github/workflows/build_release.yml Outdated Show resolved Hide resolved
.github/workflows/build_release.yml Outdated Show resolved Hide resolved
.github/workflows/build_canary.yml Outdated Show resolved Hide resolved
.github/workflows/build_canary.yml Outdated Show resolved Hide resolved
.github/workflows/build_canary.yml Outdated Show resolved Hide resolved
.github/workflows/build_canary.yml Outdated Show resolved Hide resolved
@arschles
Copy link
Collaborator

arschles commented Feb 4, 2021

Relevant links to set things up:

Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@arschles
Copy link
Collaborator

arschles commented Feb 4, 2021

@khaosdoctor thanks for making all the changes. I'm going to wait until I can get access to set up the container registry and required secrets from @tomkerkhove

.github/workflows/build_release.yml Show resolved Hide resolved
.github/workflows/build_release.yml Show resolved Hide resolved
.github/workflows/build_release.yml Show resolved Hide resolved
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created the secrets, but require a little change; sorry!

  • PACKAGES_USERNAME --> GHCR_AUTH_USER
  • PACKAGES_PASSWORD --> GHCR_AUTH_PAT

Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove
Copy link
Member

I've created the secrets, but require a little change; sorry!

  • PACKAGES_USERNAME --> GHCR_AUTH_USER
  • PACKAGES_PASSWORD --> GHCR_AUTH_PAT

We would need to change this @khaosdoctor

@khaosdoctor
Copy link
Contributor Author

Sorry I didn't see this comment!

Signed-off-by: Lucas Santos <hello@lsantos.dev>
@khaosdoctor
Copy link
Contributor Author

@tomkerkhove done

@arschles arschles merged commit 8c5a4c8 into kedacore:main Feb 5, 2021
@khaosdoctor khaosdoctor deleted the github-actions-ci branch February 5, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up CI & Push Images to GitHub Container Registry
3 participants