Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing: lookup host without port #609

Merged
merged 3 commits into from
Feb 25, 2023

Conversation

t0rr3sp3dr0
Copy link
Contributor

Move from exact match for routing table host lookup to a domain-only match, ignoring ports.

Checklist

Fixes #608

Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
@t0rr3sp3dr0 t0rr3sp3dr0 requested a review from a team as a code owner February 22, 2023 06:16
@t0rr3sp3dr0
Copy link
Contributor Author

@JorTurFer @tomkerkhove, would you be able to approve workflow runs for this PR?

@JorTurFer
Copy link
Member

Approved the CI, I'll review this PR during the day!
Thanks! ❤️

Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
@t0rr3sp3dr0
Copy link
Contributor Author

t0rr3sp3dr0 commented Feb 23, 2023

I think Validate / validate - arm64 (pull_request) is flaky. I've seen PRs that only contained doc changes and this test failed anyway. It's also failing on the master branch right now (https://github.com/kedacore/http-add-on/actions/runs/4236150711/jobs/7360624850).

I don't have permission to rerun the failed job.

@tomkerkhove
Copy link
Member

Re-running

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the contribution ❤️

@JorTurFer JorTurFer enabled auto-merge (squash) February 25, 2023 00:59
@JorTurFer JorTurFer merged commit 1bd8ba1 into kedacore:main Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requests not routed when port specified on Host header
3 participants