Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Verify manifest changes correctly #692

Merged
merged 1 commit into from
Jun 1, 2023
Merged

fix: Verify manifest changes correctly #692

merged 1 commit into from
Jun 1, 2023

Conversation

JorTurFer
Copy link
Member

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

@JorTurFer
fix: Varify manifest changes correctly
a99cc23 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer requested a review from a team as a code owner May 31, 2023 15:17
@JorTurFer JorTurFer enabled auto-merge (squash) May 31, 2023 15:17
@t0rr3sp3dr0
Copy link
Contributor

It seems we had more validation problems than I noticed 😆

@JorTurFer
Copy link
Member Author

It seems we had more validation problems than I noticed 😆

Yeah, I did some mistakes when I ported the thing from core 😅😅
At least we have detected them with only a few commits :)

@JorTurFer JorTurFer merged commit d6fe14a into kedacore:main Jun 1, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0rr3sp3dr0 t0rr3sp3dr0 t0rr3sp3dr0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JorTurFer @t0rr3sp3dr0