Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HTTPScaledObject is the owner of the underlying ScaledObject #704

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

JorTurFer
Copy link
Member

In order to delete resources in cascade, we should set the owner reference on ScaledObjects

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #703

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer marked this pull request as ready for review June 15, 2023 20:45
@JorTurFer JorTurFer requested a review from a team as a code owner June 15, 2023 20:45
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@tomkerkhove tomkerkhove merged commit ce37228 into kedacore:main Jun 16, 2023
19 checks passed
@JorTurFer JorTurFer deleted the add-owner branch June 16, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The add-on isn't the owner of the underlying ScaledObject
3 participants