Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(prometheus-scaler): 📝 Add customHeaders parameter #1064

Merged
merged 9 commits into from
Feb 27, 2023

Conversation

prashant-shahi
Copy link
Contributor

Add custom headers parameter documentation for prometheus scaler.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#4206

Signed-off-by: Prashant Shahi me@prashantshahi.dev

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>
@prashant-shahi prashant-shahi requested a review from a team as a code owner February 7, 2023 11:50
@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 3b71452
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/63f919b7df02470008b243d8
😎 Deploy Preview https://deploy-preview-1064--keda.netlify.app/docs/2.10/scalers/prometheus
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>
Signed-off-by: Prashant Shahi <me@prashantshahi.dev>
Signed-off-by: Prashant Shahi <me@prashantshahi.dev>
@prashant-shahi prashant-shahi requested review from zroubalik and JorTurFer and removed request for JorTurFer and zroubalik February 8, 2023 10:34
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation announcement needs more work.

content/docs/2.10/scalers/prometheus.md Outdated Show resolved Hide resolved
…ion policy in kedacore/governance

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>
@prashant-shahi
Copy link
Contributor Author

@tomkerkhove I have updated the deprecation messages as per the deprecation policy in KEDA governance.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @prashant-shahi !

@zroubalik zroubalik merged commit 9c1c53e into kedacore:main Feb 27, 2023
@prashant-shahi prashant-shahi deleted the docs/prometheus-headers branch March 9, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants