Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add documentation for gssapi authentication #1201

Merged
merged 16 commits into from
Oct 11, 2023
Merged

add documentation for gssapi authentication #1201

merged 16 commits into from
Oct 11, 2023

Conversation

novicr
Copy link
Contributor

@novicr novicr commented Aug 2, 2023 •
edited

Documentation regarding changes to Kafka scaler to support Kerberos authentication

PR: kedacore/keda#4851
Feature request: kedacore/keda#4836

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@novicher
add documentation for gssapi authentication
ef25c38 
Signed-off-by: Roman Novichenok <roman.novichenok@gmail.com>
@novicr novicr requested a review from a team as a code owner August 2, 2023 03:30
@netlify
Copy link

netlify bot commented Aug 2, 2023 •
edited

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit df1c41c
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6525beb556e1210008fa918d
😎 Deploy Preview https://deploy-preview-1201--keda.netlify.app/docs/2.13/scalers/prometheus
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@novicr novicr mentioned this pull request Aug 2, 2023
Merged
5 tasks
@tomkerkhove
Copy link
Member

Can you also link the issue + feature PR in the PR description please?

@novicher
reflect new name for kerberos config
edc65bb 
Signed-off-by: Roman Novichenok <roman.novichenok@gmail.com>
@novicr
Copy link
Contributor Author

novicr commented Aug 10, 2023

Can you also link the issue + feature PR in the PR description please?

updated

JorTurFer
JorTurFer reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an example about how to use this new authentication?

novicr and others added 2 commits August 19, 2023 15:36
@novicr
Merge branch 'kedacore:main' into gssapi
164756b
@novicher
add kerberos example via TriggerAuthentication
8541208 
Signed-off-by: Roman Novichenok <roman.novichenok@gmail.com>
@novicr
Copy link
Contributor Author

novicr commented Aug 19, 2023

Could you add an example about how to use this new authentication?

Added example for using gssapi auth

@novicr novicr requested a review from JorTurFer August 22, 2023 15:09
novicr and others added 4 commits August 26, 2023 16:08
@novicr
Merge branch 'kedacore:main' into gssapi
fab1054
@novicr
Merge branch 'kedacore:main' into gssapi
7365cb0
@novicher
instructions to add mount for kerberos
d50520e 
Signed-off-by: Roman Novichenok <roman.novichenok@gmail.com>
@novicher
instructions to add mount for kerberos in helm chart
eb68ff5 
Signed-off-by: Roman Novichenok <roman.novichenok@gmail.com>
zroubalik
zroubalik reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a nit

content/docs/2.12/scalers/apache-kafka.md Outdated Show resolved Hide resolved
content/docs/2.12/scalers/apache-kafka.md Outdated Show resolved Hide resolved
zroubalik
zroubalik requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this change to docs/2.13

We shipped 2.12 already.

novicr and others added 5 commits October 10, 2023 09:54
@novicr @zroubalik
Update content/docs/2.12/scalers/apache-kafka.md
063b9e6 
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: novicr <43680008+novicr@users.noreply.github.com>
@novicr @zroubalik
Update content/docs/2.12/scalers/apache-kafka.md
ba9bf7f 
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: novicr <43680008+novicr@users.noreply.github.com>
@novicr
Merge branch 'main' into gssapi
b692fdf
@novicher
move kafka docs to 2.13
fbb723a 
Signed-off-by: Roman Novichenok <roman.novichenok@gmail.com>
@novicher
move kafka docs to 2.13
071b1a4 
Signed-off-by: Roman Novichenok <roman.novichenok@gmail.com>
@novicher
move kafka docs to 2.13
3e125a1 
Signed-off-by: Roman Novichenok <roman.novichenok@gmail.com>
@novicr novicr requested a review from zroubalik October 10, 2023 14:25
@novicr novicr requested a review from zroubalik October 10, 2023 15:56
@zroubalik zroubalik merged commit e6c1037 into kedacore:main Oct 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

@JorTurFer JorTurFer Awaiting requested review from JorTurFer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@novicr @tomkerkhove @zroubalik @JorTurFer @novicher