Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka limitPartitionsWithLag docs #1241

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Kafka limitPartitionsWithLag docs #1241

merged 6 commits into from
Oct 11, 2023

Conversation

BojanZelic
Copy link
Contributor

add docs around limitPartitionsWithLag for both kafka scalers

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#3997

Dmitrii Senin and others added 3 commits April 13, 2023 13:16
Docs for limitPartitionsWithLag
1509a50 
Signed-off-by: Dmitrii Senin <white.lord.mane@gmai.com>
@BojanZelic
Merge branch 'main' of github.com:kedacore/keda-docs into kafka_activ…
a94c804 
…e_partitions
@BojanZelic
add kafka limitToPartitionsWithLag docs
ac3eb0e 
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
@BojanZelic BojanZelic requested a review from a team as a code owner October 6, 2023 22:31
@netlify
Copy link

netlify bot commented Oct 6, 2023 •
edited

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 47e7324
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65260be99bd2130008314c55
😎 Deploy Preview https://deploy-preview-1241--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@BojanZelic BojanZelic mentioned this pull request Oct 6, 2023
Merged
4 tasks
zroubalik
zroubalik reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a nit

content/docs/2.13/scalers/apache-kafka-go.md Outdated Show resolved Hide resolved
content/docs/2.13/scalers/apache-kafka.md Outdated Show resolved Hide resolved
BojanZelic and others added 3 commits October 10, 2023 19:42
@BojanZelic @zroubalik
add period
c536b88 
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
@BojanZelic @zroubalik
add period
ac3022d 
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
@BojanZelic
Merge branch 'main' into kafka_active_partitions
47e7324
@zroubalik zroubalik merged commit 47eef6c into kedacore:main Oct 11, 2023
8 checks passed
@zroubalik zroubalik mentioned this pull request Dec 21, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kafka scaler: limit number of replicas to the number of partitions with lag.
2 participants
@BojanZelic @zroubalik