Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TriggerAuthentication properties from ConfigMap #1252

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented Oct 25, 2023

This documents how to use ConfigMaps in TriggerAuthentication as implemented by kedacore/keda#5111

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

see also: kedacore/keda#4830

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 4c654af
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/653e934ca1486f000810399a
😎 Deploy Preview https://deploy-preview-1252--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@wozniakjan
Copy link
Member Author

wozniakjan commented Oct 25, 2023

I will investigate the failure a little bit later but perhaps @zroubalik or @JorTurFer can point me in the right direction here please?

3:36:03 PM:   target does not exist --- docs/2.13/authentication-providers/configmap/index.html --> /docs/2.12/authentication-providers/configmap/
3:36:04 PM: Failed during stage "building site": Build script returned non-zero exit code: 2

does this mean it has to be in 2.13 as well as 2.12? I tried to follow the contrib docs
https://github.com/kedacore/keda-docs#writing-documentation-for-a-new-authentication-provider

$ hugo new --kind provider content/docs/2.13/authentication-providers/configmap.md
WARN  DEPRECATED: Kind "taxonomyterm" used in disableKinds is deprecated, use "taxonomy" instead.
Content "/home/wozy/projects/go/src/github.com/kedacore/keda-docs/content/docs/2.13/authentication-providers/configmap.md" created

@zroubalik
Copy link
Member

I will investigate the failure a little bit later but perhaps @zroubalik or @JorTurFer can point me in the right direction here please?

3:36:03 PM:   target does not exist --- docs/2.13/authentication-providers/configmap/index.html --> /docs/2.12/authentication-providers/configmap/
3:36:04 PM: Failed during stage "building site": Build script returned non-zero exit code: 2

does this mean it has to be in 2.13 as well as 2.12? I tried to follow the contrib docs https://github.com/kedacore/keda-docs#writing-documentation-for-a-new-authentication-provider

$ hugo new --kind provider content/docs/2.13/authentication-providers/configmap.md
WARN  DEPRECATED: Kind "taxonomyterm" used in disableKinds is deprecated, use "taxonomy" instead.
Content "/home/wozy/projects/go/src/github.com/kedacore/keda-docs/content/docs/2.13/authentication-providers/configmap.md" created

The problem is not on your side, we just need to add each new page in https://github.com/kedacore/keda-docs/blob/main/.htmltest.yml like this: e03ee09

@wozniakjan wozniakjan marked this pull request as ready for review October 26, 2023 16:53
@wozniakjan wozniakjan requested a review from a team as a code owner October 26, 2023 16:53
@zroubalik
Copy link
Member

@wozniakjan could you please add an exception for this file into the .htmltest.yml file?

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@zroubalik zroubalik merged commit db2e4b0 into kedacore:main Oct 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants