Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce Azure Event Grid as a new CloudEvent destination #1336

Merged
merged 15 commits into from
Apr 22, 2024

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Mar 15, 2024

Update doc about new AzureEventGrid destination

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#3587
Relates to kedacore/keda#5606

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou requested a review from a team as a code owner March 15, 2024 08:47
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit bb6db79
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/661f6089dd86e800084dedc7
😎 Deploy Preview https://deploy-preview-1336--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions/questions

content/docs/2.14/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.14/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.14/operate/events.md Outdated Show resolved Hide resolved
SpiritZhou and others added 2 commits March 18, 2024 16:16
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
content/docs/2.14/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.14/operate/events.md Outdated Show resolved Hide resolved
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
content/docs/2.14/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.14/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.14/operate/events.md Outdated Show resolved Hide resolved
@tomkerkhove tomkerkhove changed the title Update doc about new AzureEventGrid destination feat: Introduce Azure Event Grid as a new CloudEvent destination Apr 16, 2024
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
content/docs/2.14/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.14/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.14/operate/events.md Show resolved Hide resolved
content/docs/2.14/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.14/operate/events.md Outdated Show resolved Hide resolved
content/docs/2.14/operate/events.md Show resolved Hide resolved
content/docs/2.14/operate/events.md Show resolved Hide resolved
SpiritZhou and others added 6 commits April 17, 2024 13:32
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for feature to be merged

@tomkerkhove tomkerkhove merged commit 31251ff into kedacore:main Apr 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants