Add explanations for validations.keda.sh/hpa-ownership
#1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: June Han <sorrowitsch@gmail.com>
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zroubalik
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Please move this to 2.14. The version 2.13 is already out.
Also could you please add also a short paragraph to: https://keda.sh/docs/2.14/operate/admission-webhooks/ ?
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: June Han <sorrowitsch@gmail.com>
Signed-off-by: June Han <sorrowitsch@gmail.com>
Signed-off-by: June Han <sorrowitsch@gmail.com>
Signed-off-by: June Han <sorrowitsch@gmail.com>
|
All done! |
zroubalik
reviewed
Apr 11, 2024
Signed-off-by: June Han <sorrowitsch@gmail.com>
JorTurFer
approved these changes
Apr 11, 2024
zroubalik
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explanations for
validations.keda.sh/hpa-ownershipChecklist
Fixes
kedacore/keda#5536