Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit tests for container args #25

Merged
merged 2 commits into from
May 1, 2020
Merged

unit tests for container args #25

merged 2 commits into from
May 1, 2020

Conversation

samuelmacko
Copy link
Contributor

#19

Signed-off-by: smacko samuel.macko.sm@gmail.com

Signed-off-by: smacko <samuel.macko.sm@gmail.com>
Makefile Outdated
##################################################
.PHONY: test-unit
test-unit:
go test ./...
Copy link
Member

@zroubalik zroubalik May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$(GO_BUILD_VARS) go test ./...

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, great work! One minor nit

@zroubalik zroubalik mentioned this pull request May 1, 2020
Signed-off-by: smacko <samuel.macko.sm@gmail.com>
@samuelmacko samuelmacko requested a review from zroubalik May 1, 2020 13:31
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@zroubalik zroubalik merged commit b6b926f into kedacore:master May 1, 2020
joelsmith pushed a commit to joelsmith/keda-olm-operator that referenced this pull request Mar 23, 2023
Move olm.skipRange from metadata to annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants